Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1302 +/- ##
==========================================
Coverage 86.71% 86.71%
==========================================
Files 337 337
Lines 83979 83980 +1
Branches 4750 3124 -1626
==========================================
+ Hits 72826 72827 +1
- Misses 11130 11153 +23
+ Partials 23 0 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the parsing of tags and attributes more compliant with he HTML5 spec, which has much looser parameters for tag and attribute names. XML parsing is more restrictive, but since the parser must work for both (it is not very sophisticated), it needs to use the less restrictive version (HTML5).
The main change is that attribute names don't have to start with a letter. The other restrictions remove the control characters and the other disallowed characters. See #1297 for some discussion of the specs.