Skip to content

Don't use padding for horizontal stretchy extenders. (mathjax/MathJax#3429)#1347

Merged
dpvc merged 2 commits intodevelopfrom
issue3429
Oct 10, 2025
Merged

Don't use padding for horizontal stretchy extenders. (mathjax/MathJax#3429)#1347
dpvc merged 2 commits intodevelopfrom
issue3429

Conversation

@dpvc
Copy link
Copy Markdown
Member

@dpvc dpvc commented Sep 6, 2025

This PR fixes a problem with horizontal stretchy character assemblies with middle pieces (like over- and under-braces) where the width is relatively small. The unneeded padding was causing the size to be incorrect when the total padding was larger than the width of the needed extender.

Resolves issue mathjax/MathJax#3429.

@dpvc dpvc requested a review from zorkow September 6, 2025 18:43
@dpvc dpvc added this to the v4.0.1 milestone Sep 6, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 6, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.71%. Comparing base (afaf1ea) to head (91b1c2d).
⚠️ Report is 32 commits behind head on develop.

Files with missing lines Patch % Lines
ts/output/chtml/FontData.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1347      +/-   ##
===========================================
- Coverage    86.72%   86.71%   -0.01%     
===========================================
  Files          337      337              
  Lines        84145    84148       +3     
  Branches      3140     4769    +1629     
===========================================
  Hits         72971    72971              
+ Misses       11174    11154      -20     
- Partials         0       23      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 98a31f5 into develop Oct 10, 2025
2 of 3 checks passed
@dpvc dpvc deleted the issue3429 branch October 10, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants