Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1362 +/- ##
===========================================
- Coverage 86.72% 86.71% -0.01%
===========================================
Files 337 337
Lines 84145 84155 +10
Branches 3140 4769 +1629
===========================================
+ Hits 72971 72977 +6
- Misses 11174 11178 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem where margin CSS styles aren't properly handled by the
Stylesobject. This is becausemarginwasn't set in theconnectionsarray, so settingmargindidn't propagate tomargin-left, etc. This means that whenmargin-leftwas set earlier and thenmarginis set to''later, themargin-leftsetting is not cleared. That lead to extra margin settings in the example given in mathjax/MathJax#3443.This PR adds the
marginconnections, and adds more tests for margins, and for overriding connections when the main property is set.It also checks that the left and right margins aren't zero when setting them for shifting the output in the CHTML
Wrapperobject. This is just to keep the CSS minimal.