Allow cleanAttributes to work on nodes with no attributes (e.g., XML nodes)#1368
Merged
Allow cleanAttributes to work on nodes with no attributes (e.g., XML nodes)#1368
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1368 +/- ##
========================================
Coverage 86.66% 86.66%
========================================
Files 338 338
Lines 84269 84270 +1
Branches 4784 4785 +1
========================================
+ Hits 73032 73033 +1
Misses 11214 11214
Partials 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the TeX input jax's
cleanAttributes()filter to work with nodes that don't have attributes (like XML nodes). Currently, it will crash with an error about not being able to callget()on an undefined value.