Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1416 +/- ##
========================================
Coverage 86.51% 86.51%
========================================
Files 340 340
Lines 85992 85992
Branches 3184 3184
========================================
Hits 74397 74397
Misses 11595 11595 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dpvc
force-pushed
the
fix/voicing-alpha
branch
from
a5e6d2f to
27f01ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the alpha for the self-voicing red color to be .8 rather than .2, which makes it more visible. It seems to work pretty well in both light and dark modes. We can make it be 1 rather than .8, if you prefer.