Skip to content

fix(dockview-core): use visibility:hidden instead of display:none for… #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mathuo wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −12
Open

fix(dockview-core): use visibility:hidden instead of display:none for… #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions packages/dockview-core/src/__tests__/overlay/overlayRenderContainer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ describe('overlayRenderContainer', () => {
expect(panelContentEl.parentElement).toBe(container);
expect(container.parentElement).toBe(parentContainer);

expect(container.style.display).toBe('');
expect(container.style.visibility).toBe('');
expect(container.style.pointerEvents).toBe('');

expect(container.style.left).toBe('50px');
expect(container.style.top).toBe('100px');
Expand All @@ -181,7 +182,8 @@ describe('overlayRenderContainer', () => {

onDidDimensionsChange.fire({});
await exhaustAnimationFrame();
expect(container.style.display).toBe('');
expect(container.style.visibility).toBe('');
expect(container.style.pointerEvents).toBe('');

expect(container.style.left).toBe('49px');
expect(container.style.top).toBe('99px');
Expand All @@ -193,22 +195,25 @@ describe('overlayRenderContainer', () => {

(panel as Writable<IDockviewPanel>).api.isVisible = false;
onDidVisibilityChange.fire({});
expect(container.style.display).toBe('none');
expect(container.style.visibility).toBe('hidden');
expect(container.style.pointerEvents).toBe('none');
expect(
referenceContainer.element.getBoundingClientRect
).toHaveBeenCalledTimes(2);

(panel as Writable<IDockviewPanel>).api.isVisible = true;
onDidVisibilityChange.fire({});
expect(container.style.display).toBe('');
expect(container.style.pointerEvents).toBe('');
await exhaustAnimationFrame();
expect(container.style.visibility).toBe('');

expect(container.style.left).toBe('49px');
expect(container.style.top).toBe('99px');
expect(container.style.width).toBe('101px');
expect(container.style.height).toBe('201px');
expect(container.style.left).toBe('50px');
expect(container.style.top).toBe('100px');
expect(container.style.width).toBe('100px');
expect(container.style.height).toBe('200px');
expect(
referenceContainer.element.getBoundingClientRect
).toHaveBeenCalledTimes(2);
).toHaveBeenCalledTimes(3);
});

test('related z-index from `aria-level` set on floating panels', async () => {
Expand Down
8 changes: 5 additions & 3 deletions packages/dockview-core/src/overlay/overlayRenderContainer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,11 @@ export class OverlayRenderContainer extends CompositeDisposable {
if (panel.api.isVisible) {
this.positionCache.invalidate();
resize();
focusContainer.style.pointerEvents = '';
} else {
focusContainer.style.visibility = 'hidden';
focusContainer.style.pointerEvents = 'none';
}

focusContainer.style.display = panel.api.isVisible ? '' : 'none';
};

const observerDisposable = new MutableDisposable();
Expand Down Expand Up @@ -261,7 +263,7 @@ export class OverlayRenderContainer extends CompositeDisposable {
* the dnd events for the expect behaviours to continue to occur in terms of dnd
*
* the dnd observer does not need to be conditional on whether the panel is visible since
* non-visible panels are 'display: none' and in such case the dnd observer will not fire.
* non-visible panels have 'pointer-events: none' and in such case the dnd observer will not fire.
*/
new DragAndDropObserver(focusContainer, {
onDragEnd: (e) => {
Expand Down
Loading