Skip to content

Strict time validation + antagonist suite + compute refactor#19

Merged
matiasandina merged 8 commits intomainfrom
refactor-compute
Jan 29, 2026
Merged

Strict time validation + antagonist suite + compute refactor#19
matiasandina merged 8 commits intomainfrom
refactor-compute

Conversation

@matiasandina
Copy link
Copy Markdown
Owner

Summary

  • Adds strict time validation for samples/intervals/alignment to prevent silent bad output.
  • Introduces antagonist test suite + fixtures and a triage doc/roadmap updates.
  • Refactors compute helpers and refreshes docs/tests/demo data.

Key changes

  • Strict time checks: x/xend must be complete and time-like; non-monotonic x now errors; explicit interval must be finite and > 0.
  • Intervals now error on xend < x and warn on xend == x.
  • Alignment now errors if x/xend contain missing/non-finite values.
  • New antagonist cases and combined entrypoint script.
  • Updated demos, snapshots, and compute tests.

Breaking-ish behavior

  • Previously tolerated inputs (NA x/xend, non-monotonic x, invalid interval) now error.

Testing

  • Rscript tests/antagonist/ggethos_attack_all.R

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are degenerating into barplots ?

Copy link
Copy Markdown
Owner Author

@matiasandina matiasandina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major refactor passing checks. We'll continue testing and using improvement roadmap

@matiasandina matiasandina merged commit 5d0eb82 into main Jan 29, 2026
1 check passed
@matiasandina matiasandina deleted the refactor-compute branch January 29, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant