Open
Conversation
sgiehl
added
c: Documentation
sgiehl
force-pushed
the
apidocs_annotations
branch
from
9ea036d to
7073205
Compare
sgiehl
force-pushed
the
apidocs_annotations
branch
from
c68c477 to
09b2669
Compare
sgiehl
force-pushed
the
apidocs_annotations
branch
from
09b2669 to
fcf33b3
Compare
nathangavin
requested changes
Mar 31, 2026
Contributor
nathangavin
left a comment
nathangavin
left a comment
There was a problem hiding this comment.
What is the reasoning behind removing the @throws tags?
| /** | ||
| * @return array<int,array<string,string|int|bool>> | ||
| * @throws \Exception | ||
| * @return list<Annotation> |
Contributor
There was a problem hiding this comment.
Suggested change
| * @return list<Annotation> | |
| * @return array<Annotation> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Review