Adds code to delete all the access if no access returned from Ldap and enable_synchronize_access_from_ldap=1, #PG-4868 #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d enable_synchronize_access_from_ldap=1, #PG-4868
LdapInterop/UserSynchronizer.php
Outdated
Comment on lines
204
to
208
| } else { | ||
| $this->logger->log('warning', "UserSynchronizer::{func}: User '{user}' has no access in LDAP, but access synchronization is enabled.", array( | ||
| 'func' => __FUNCTION__, | ||
| 'user' => $piwikLogin | ||
| )); |
Contributor
There was a problem hiding this comment.
@AltamashShaikh Not sure if this is ready for review yet, but this error message is now wrong. Is there any case where accessSynchronization is disabled and this function is called? I don't think there should be - having the if is nice, but maybe it should be further up the stack?
Contributor
Contributor
Author
|
@james-hill-matomo Thanks for the suggestion, I have applied them here and updated the test case to be check the behaviour more accurately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds code to delete all the access if no access returned from Ldap and enable_synchronize_access_from_ldap=1
Issue No
#PG-4868
Steps to Replicate the Issue
Checklist