fix: spec compliant token verification #501
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Debdut Chakraborty <[email protected]>
debdutdeb
force-pushed
the
spec-compliant-token-checking
branch
from
1334c64 to
4730173
Compare
tadzik
reviewed
Sep 13, 2024
Contributor
tadzik
left a comment
tadzik
left a comment
There was a problem hiding this comment.
LGTM aside of the vi marker
| } | ||
| } | ||
|
|
||
| // vi: et sw=4 ts=4 |
Contributor
There was a problem hiding this comment.
Looks like an accidental leftover
Half-Shot
reviewed
Sep 16, 2024
|
|
||
| const tokenFromQuery = req.query.access_token; | ||
|
|
||
| const tokenFromHeader = req.get("authorization").substring(7); // "Bearer ".length === 7 |
Contributor
There was a problem hiding this comment.
Should we check for "Bearer "?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.