Skip to content

Fix nedb's usage of node:utils for Node 24 #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix nedb's usage of node:utils for Node 24 #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f174e7d
Fix nedb's utils for Node 24, not just in tests
AndrewFerr Sep 2, 2025
de22f78
Print deprecation warning when using nedb
AndrewFerr Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions spec/integ/bridge.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@
const Datastore = require("nedb");
const fs = require("fs");

// required fix for nedb being incredibly outdated
const util = require("node:util");
util.isDate = util.types.isDate;
util.isRegExp = util.types.isRegExp;

const HS_URL = "http://example.com";
const HS_DOMAIN = "example.com";
const BOT_LOCALPART = "the_bridge";
Expand Down
8 changes: 8 additions & 0 deletions src/bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1721,8 +1721,16 @@ export class Bridge {
}

async function loadDatabase<T extends BridgeStore>(path: string, Cls: new (db: Datastore) => T) {
log.warn("NeDB-based stores are now deprecated.");
try {
const datastoreFn = (await import("nedb")).default;
// required fix for nedb being incredibly outdated
if (parseInt(process.versions.node.split(".")[0]) >= 24) {
const util = require("node:util");
util.isDate = util.types.isDate;
util.isRegExp = util.types.isRegExp;
}

return new Promise<T>((resolve, reject) => {
const dbInstance = new datastoreFn({
filename: path,
Expand Down
Loading