fix: precaching of all transactions causes errors#766
Open
NickUfer wants to merge 13 commits intomatrix-org:developfrom
Open
fix: precaching of all transactions causes errors#766NickUfer wants to merge 13 commits intomatrix-org:developfrom
NickUfer wants to merge 13 commits intomatrix-org:developfrom
Conversation
Contributor
|
Kinda sad to see that this is still marked as draft and has no responses so far... |
…ionCompleted are completed
f06b46f to
a17907f
Compare
Author
|
Tested it, works fine Lets see what the CI says, otherwise should be ready to review |
feat: adds name to TimedCache for silly logging
Author
|
Added log.silly for cache pruning, works too |
…HE_LIFETIME_MILLIS to amount of usage
test: fixes tests to close DiscordStorage after usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the storage implementation to only load users and transaction ids when they are needed. Recent queries for txIds and users are cached. This fix also reduces memory consumption.
Fixes #765