feat: add external_url to normal messages bridged from discord#860
Open
SethFalco wants to merge 1 commit intomatrix-org:developfrom
Open
feat: add external_url to normal messages bridged from discord#860SethFalco wants to merge 1 commit intomatrix-org:developfrom
SethFalco wants to merge 1 commit intomatrix-org:developfrom
Conversation
Signed-off-by: Seth Falco <seth@falco.fun>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
external_urlfield to normal Discord messages too. Users with Discord can then access it to check the same message on the Discord side.This leaves an intentional inconsistency with attachments. Attachments bridged over from Discord have an
external_urlto the direct download link from Discord servers. A bit more on that in the original issue.Related