Make bridgeInfoState configuration reloadable #1681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be useful for tests
Contributor
Author
|
Signed-off-by: Valentin Lorentz <progval plus matrixsignoff at progval dot net> |
This was referenced Mar 11, 2023
Half-Shot
requested changes
Apr 5, 2023
src/bridge/IrcBridge.ts
Outdated
| }); | ||
| if (config.ircService.bridgeInfoState.initial) { | ||
| const mappings = await this.dataStore.getAllChannelMappings(); | ||
| this.bridgeStateSyncer.initialSync(mappings).then(() => { |
Contributor
There was a problem hiding this comment.
I wonder if this is a subtle-y expensive operation that might be a bit surprising on reload. I think if the config hasn't changed, we shouldn't attempt a resync.
I'm slightly more open to a resync if initial has changed.
Co-authored-by: Will Hunt <[email protected]>
Half-Shot
requested changes
Apr 12, 2023
Half-Shot
approved these changes
Apr 26, 2023
Contributor
Half-Shot
left a comment
Half-Shot
left a comment
There was a problem hiding this comment.
LGTM, will merge in a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful for tests in #1683