Conversation
`mediaProxy` was being passed in twice
Required by incoming matrix-appservice-bridge update
Update `matrix-appservice-bridge` to fix `IO.ELEMENT.MSC4190.M_APPSERVICE_LOGIN_UNSUPPORTED` error with MSC4190 enabled homeservers. A few await's needed as either the methods are now async OR we were previously trying to feed promises into strings.
AndrewFerr
reviewed
Oct 22, 2025
AndrewFerr
requested changes
Oct 22, 2025
Co-authored-by: Andrew Ferrazzutti <andrewf@element.io>
Co-authored-by: Andrew Ferrazzutti <andrewf@element.io>
Co-authored-by: Andrew Ferrazzutti <andrewf@element.io>
Co-authored-by: Andrew Ferrazzutti <andrewf@element.io>
AndrewFerr
approved these changes
Oct 23, 2025
Member
AndrewFerr
left a comment
AndrewFerr
left a comment
There was a problem hiding this comment.
The test failures in Node 24 are because of nedb having rotted, which ought to be fixed in the bridge SDK (see matrix-org/matrix-appservice-bridge#521).
With that said, this PR looks good to go. Just consider dropping eslint-plugin-tslint.
Co-authored-by: Andrew Ferrazzutti <andrewf@element.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few await's needed as either the methods are now async OR we were previously trying to feed promises into strings.
Also required updating Node to 22 due to above dependency bump. A few tests were generally failing, so made those pass, it seemed like we're passing information in twice.