Skip to content

Fix migration from schema <= 12 to schema > 16. Issue #1282#1284

Open
N-Pex wants to merge 1 commit intomatrix-org:developfrom
N-Pex:1282-fix-migration-issue
Open

Fix migration from schema <= 12 to schema > 16. Issue #1282#1284
N-Pex wants to merge 1 commit intomatrix-org:developfrom
N-Pex:1282-fix-migration-issue

Conversation

@N-Pex
Copy link
Copy Markdown
Contributor

@N-Pex N-Pex commented Nov 3, 2021

Signed-off-by: N-Pex npexdev@gmail.com

Pull Request Checklist

@pixlwave
Copy link
Copy Markdown
Member

Thanks for the PR @N-Pex and sorry for the long delay in reviewing. This looks good to me, although there is one small tweak we could make:

  • It would make more sense to wrap the entire enumerateObjects call in the new if block, as there is no need to run this step if it's not going to perform any actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants