Conversation
since we don't really release the app anymore on cocoapods, and there is an issue with the libbase58 library that only allows linting to work with up to Xcode14.2, even if the project can build with newer versions.
manuroe
approved these changes
Mar 11, 2025
Contributor
manuroe
left a comment
manuroe
left a comment
There was a problem hiding this comment.
It is fine by me.
Thanks for the cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we don't release anymore the library on cocoapods, and there is an issue with Cocoapods that only allows linting to work with up to Xcode 14.2 with the libbase58 library, even if the project can be built with newer versions... then we decided to just get rid of this workflow entirely.
We could run the linting and just the linting with an older version, but this feels like a waste of resources given the fact that as mentioned above, we don't publish on cocapods anymore