Conversation
- added the `additional_creators` field in the m.room.create event - the creator is now determined as the sender of the m.room.create event - power levels check for creator first and return the max possible PL in that case before checking the power levels event
…e one from `MXRoomState`
Velin92
commented
Jul 22, 2025
pixlwave
reviewed
Jul 23, 2025
pixlwave
approved these changes
Jul 23, 2025
stefanceriu
approved these changes
Jul 23, 2025
Member
stefanceriu
left a comment
stefanceriu
left a comment
There was a problem hiding this comment.
Not particularly familiar with the code but this looks sensible to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Room creator will now have the highest possible power level, which won't be determined by
m.room.power_levels.Also a room may have additional creators.
Also the
powerLevelOfUserWithUserIDfunction from MXPowerLevels has been removed in favour of the newer version inMXRoomState.