Skip to content

Mark room versions 7, 8, and 9 as safe #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2022
Merged

Mark room versions 7, 8, and 9 as safe #2318

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4128c5a
Mark room versions 7, 8, and 9 as safe
aaronraimist Apr 25, 2022
7995086
Update KNOWN_SAFE_ROOM_VERSION to room version 9
aaronraimist Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/models/room.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ import { TypedEventEmitter } from "./typed-event-emitter";
// room versions which are considered okay for people to run without being asked
// to upgrade (ie: "stable"). Eventually, we should remove these when all homeservers
// return an m.room_versions capability.
const KNOWN_SAFE_ROOM_VERSION = '6';
const SAFE_ROOM_VERSIONS = ['1', '2', '3', '4', '5', '6'];
const KNOWN_SAFE_ROOM_VERSION = '9';
Copy link
Member

@t3chguy t3chguy Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice, KNOWN_SAFE_ROOM_VERSION should be the same as the common default room version

Hmm @turt2live you sure about this given the spec is still saying default to 6

Copy link
Member

@turt2live turt2live Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing spec at the moment: matrix-org/matrix-spec-proposals#3739

const SAFE_ROOM_VERSIONS = ['1', '2', '3', '4', '5', '6', '7', '8', '9'];

function synthesizeReceipt(userId: string, event: MatrixEvent, receiptType: string): MatrixEvent {
// console.log("synthesizing receipt for "+event.getId());
Expand Down