Skip to content

Factor out a (public) function to find a room's predecessor #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2023
Merged

Factor out a (public) function to find a room's predecessor #3039

merged 3 commits into from
Jan 10, 2023

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Jan 9, 2023 •
edited by github-actions bot
Loading

This is prep for an implementation of MSC3946

This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Tasks for the team like planning label Jan 9, 2023
@andybalaam andybalaam force-pushed the factor-out-findPredecessor branch from 2e28855 to 1060335 Compare January 9, 2023 15:24
@andybalaam andybalaam force-pushed the factor-out-findPredecessor branch from 014d39e to 999e355 Compare January 10, 2023 10:16
@andybalaam andybalaam marked this pull request as ready for review January 10, 2023 10:30
@andybalaam andybalaam requested a review from a team as a code owner January 10, 2023 10:30
richvdh
richvdh approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSC3946 seems to be under fierce debate, so I'd be hesitant about implementing it right now.

Nevertheless factoring code out to functions is a win!

@andybalaam andybalaam enabled auto-merge January 10, 2023 13:42
@andybalaam andybalaam merged commit 3564a35 into matrix-org:develop Jan 10, 2023
@andybalaam andybalaam deleted the factor-out-findPredecessor branch January 10, 2023 13:44
@andybalaam andybalaam mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richvdh richvdh richvdh approved these changes

@SimonBrandner SimonBrandner Awaiting requested review from SimonBrandner SimonBrandner is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

No one assigned

Labels

T-Task Tasks for the team like planning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andybalaam @richvdh