Skip to content

Navigation Menu

Appearance settings

GitHub Copilot
Write better code with AI

GitHub Spark New
Build and deploy intelligent apps

GitHub Models New
Manage and compare prompts

GitHub Advanced Security
Find and fix vulnerabilities

Actions
Automate any workflow
Codespaces
Instant dev environments

Issues
Plan and track work

Code Review
Manage code changes

Discussions
Collaborate outside of code

Code Search
Find more, search less
Explore

Why GitHub

Documentation

GitHub Skills

Blog
Integrations

GitHub Marketplace

MCP Registry
View all features
By company size

Enterprises

Small and medium teams

Startups

Nonprofits
By use case

App Modernization

DevSecOps

DevOps

CI/CD

View all use cases
By industry

Healthcare

Financial services

Manufacturing

Government

View all industries
View all solutions
Topics

AI

DevOps

Security

Software Development

View all
Explore

Learning Pathways

Events & Webinars

Ebooks & Whitepapers

Customer Stories

Partners

Executive Insights
GitHub Sponsors
Fund open source developers
The ReadME Project
GitHub community articles
Repositories

Topics

Trending

Collections
Enterprise platform
AI-powered developer platform
Available add-ons

GitHub Advanced Security
Enterprise-grade security features

Copilot for business
Enterprise-grade AI features

Premium Support
Enterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

matrix-org / matrix-js-sdk Public

Fork 648
Star 1.9k

Code
Issues 238
Pull requests 16
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

Ensure we do not add relations to the wrong timeline#3427

Merged

t3chguy merged 19 commits intodevelopmatrix-org/matrix-js-sdk:developfrom

t3chguy/fix/25450matrix-org/matrix-js-sdk:t3chguy/fix/25450Copy head branch name to clipboard

Jun 1, 2023

Conversation Commits19 (19)Checks Files changed

Merged

Ensure we do not add relations to the wrong timeline#3427
t3chguy merged 19 commits intodevelopfrom
t3chguy/fix/25450

Commits

Commits on May 31, 2023

Do not assume that a relation lives in main timeline if we do not know its parent
t3chguy
committed
For pagination, partition relations with unknown parents into a separate bucket
t3chguy
committed
Make addLiveEvents async and have it fetch parent events of unknown relations to not insert into the wrong timeline
t3chguy
committed
Fix tests not awaiting addLIveEvents
t3chguy
committed
Fix handling of thread roots in eventShouldLiveIn
t3chguy
committed
Fix types
t3chguy
committed
Fix tests
t3chguy
committed
Fix import
t3chguy
committed
Stash thread ID of relations in unsigned to be stashed in sync accumulator
t3chguy
committed
Persist after processing
t3chguy
committed
Revert "Persist after processing"
t3chguy
committed
Update unsigned field name to match MSC4023
t3chguy
committed
Persist after processing to store thread id in unsigned sync accumulator
t3chguy
committed

Commits on Jun 1, 2023

Add test
t3chguy
committed
Fix replayEvents getting doubled up due to Thread::addEvents being called in createThread and separately
t3chguy
committed
Fix test
t3chguy
committed
Switch to using UnstableValue
t3chguy
committed
Add comment
t3chguy
committed
Iterate
t3chguy
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.