Skip to content

Bump dependency on rust-sdk-crypto-wasm to v8.0.0 #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2024
Merged

Bump dependency on rust-sdk-crypto-wasm to v8.0.0 #4396

merged 2 commits into from
Sep 13, 2024

Conversation

@uhoreg
Copy link
Member

@uhoreg uhoreg commented Sep 10, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@uhoreg uhoreg added the T-Task Tasks for the team like planning label Sep 10, 2024
@uhoreg uhoreg requested review from a team as code owners September 10, 2024 16:29
richvdh
richvdh reviewed Sep 10, 2024
View reviewed changes
@uhoreg uhoreg requested a review from richvdh September 11, 2024 02:44
richvdh
richvdh approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richvdh richvdh added this pull request to the merge queue Sep 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024
@richvdh richvdh added this pull request to the merge queue Sep 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024
@richvdh
Copy link
Member

richvdh commented Sep 11, 2024

looks like something is failing in the playwright tests :/

This was referenced Sep 11, 2024
Closed
Closed
@uhoreg uhoreg mentioned this pull request Sep 11, 2024
Merged
4 tasks
@uhoreg uhoreg added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@richvdh
Copy link
Member

richvdh commented Sep 13, 2024

element-hq/matrix-react-sdk#32 fixes the react-sdk, but neither can merge without the other. Overriding the merge queue.

@richvdh richvdh merged commit 7987ce7 into matrix-org:develop Sep 13, 2024
22 checks passed
@hughns hughns mentioned this pull request Sep 18, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richvdh richvdh richvdh approved these changes

@florianduros florianduros florianduros approved these changes

@BillCarsonFr BillCarsonFr Awaiting requested review from BillCarsonFr BillCarsonFr is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

Assignees

No one assigned

Labels

T-Task Tasks for the team like planning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@uhoreg @richvdh @florianduros