Skip to content

Add unstable support for MSC4472 #5326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
timedoutuk wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Add unstable support for MSC4472 #5326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee27a61
Add unstable support for MSC4472
timedoutuk May 15, 2026
e0800cd
Reformat with prettier
timedoutuk May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/models/room.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ import { compareEventOrdering } from "./compare-event-ordering.ts";
import { KnownMembership, type Membership } from "../@types/membership.ts";
import { type Capabilities, type IRoomVersionsCapability, RoomVersionStability } from "../serverCapabilities.ts";
import { type MSC4186Hero } from "../sliding-sync.ts";
import { RoomStickyEventsStore, RoomStickyEventsEvent, type RoomStickyEventsMap } from "./room-sticky-events.ts";
import { RoomStickyEventsEvent, type RoomStickyEventsMap, RoomStickyEventsStore } from "./room-sticky-events.ts";

// These constants are used as sane defaults when the homeserver doesn't support
// the m.room_versions capability. In practice, KNOWN_SAFE_ROOM_VERSION should be
Expand Down Expand Up @@ -108,6 +108,7 @@ export interface IRecommendedVersion {
version: string;
needsUpgrade: boolean;
urgent: boolean;
deprecated: boolean;
}

// When inserting a visibility event affecting event `eventId`, we
Expand Down Expand Up @@ -685,20 +686,22 @@ export class Room extends ReadReceipt<RoomEmittedEvents, RoomEventHandlerMap> {
version: currentVersion,
needsUpgrade: false,
urgent: false,
deprecated: false,
};

// If the room is on the default version then nothing needs to change
if (currentVersion === versionCap.default) return result;

const stableVersions = Object.keys(versionCap.available).filter((v) => versionCap.available[v] === "stable");
const currentStability = versionCap.available[currentVersion] ?? RoomVersionStability.Unstable;

// Check if the room is on an unstable version. We determine urgency based
// off the version being in the Matrix spec namespace or not (if the version
// is in the current namespace and unstable, the room is probably vulnerable).
if (!stableVersions.includes(currentVersion)) {
if (currentStability !== RoomVersionStability.Stable) {
result.version = versionCap.default;
result.deprecated = currentStability === RoomVersionStability.Deprecated;
result.needsUpgrade = true;
result.urgent = !!this.getVersion().match(/^[0-9]+[0-9.]*$/g);
result.urgent = result.deprecated || !!this.getVersion().match(/^[0-9]+[0-9.]*$/g);
if (result.urgent) {
logger.warn(`URGENT upgrade required on ${this.roomId}`);
} else {
Expand Down
1 change: 1 addition & 0 deletions src/serverCapabilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export interface IProfileFieldsCapability extends ICapability {}
export enum RoomVersionStability {
Stable = "stable",
Unstable = "unstable",
Deprecated = "uk.timedout.msc4472.deprecated",
}

export interface IRoomVersionsCapability {
Expand Down
Loading