Fix for sticky event duration resets on page refresh - #5432
Open
crime-think wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
the
Z-Community-PR
Member
|
Please update your title to make sense as a changelog entry |
crime-think
changed the title
t3chguy
reviewed
Jul 20, 2026
t3chguy
left a comment
t3chguy
left a comment
Member
There was a problem hiding this comment.
This could do with a test of some description
Half-Shot
self-requested a review
July 30, 2026 09:06
dbkr
reviewed
Aug 27, 2026
dbkr
left a comment
dbkr
left a comment
Member
There was a problem hiding this comment.
Where does msc4354_sticky_ttl_start_ms come from? The MSC doesn't mention it.
Also, yes, test please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #5206 by using absolute time alongside duration