Support passing an async function to do X.509 signing - #5483
Open
andybalaam wants to merge 2 commits into
Open
Conversation
andybalaam
force-pushed
the
andybalaam/x509-async-signing
branch
3 times, most recently
from
August 24, 2026 16:15
fc40246 to
48c150d
Compare
andybalaam
force-pushed
the
andybalaam/x509-async-signing
branch
from
August 25, 2026 11:02
48c150d to
889c2f8
Compare
Also requires a validity function.
andybalaam
force-pushed
the
andybalaam/x509-async-signing
branch
from
August 25, 2026 11:35
889c2f8 to
03c4f58
Compare
Member
Author
|
This is ready except it's blocked by https://github.com/element-hq/crypto-internal/issues/461 |
dbkr
requested changes
Aug 25, 2026
| * Optional async function for signing some data with an X.509 certificate. | ||
| * Used to sign the user's identity so compatible clients will recognise | ||
| * this user as verified without manual verification taking place. If you | ||
| * supply this you must also supply rawX509Validity. |
Member
There was a problem hiding this comment.
Docs refer to raw prefixed functions which doesn't match the names? (Also, should they have some kind of link annotation?)
| ## ✨ Features | ||
|
|
||
| * Allow passing a signing function when setting up Rust crypto ([#5483](https://github.com/matrix-org/matrix-js-sdk/pull/5483)). Contributed by @andybalaam. | ||
|
|
Member
There was a problem hiding this comment.
This file is auto generated: just make the PR title your changelog entry and it will do the right thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.