This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix getRelationsForEvent under TypeScript strict mode
#9558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
added
the
T-Task
MadLittleMods
commented
Nov 8, 2022
MadLittleMods
commented
Nov 8, 2022
MadLittleMods
commented
Nov 8, 2022
| eventId: string, | ||
| relationType: RelationType | string, | ||
| eventType: EventType | string, | ||
| ) => Relations | null | undefined; |
There was a problem hiding this comment.
Not every event has relations so of course we should be able to return undefined.
Unless of course there can be an empty Relations object? Since Relations(relationType, eventType, client) requires relationType I don't think this is the case.
MadLittleMods
commented
Nov 8, 2022
MadLittleMods
changed the title
getRelationsForEvent tsc strictnessgetRelationsForEvent under TypeScript strict mode
weeman1337
approved these changes
Nov 9, 2022
| "the top answer - assuming no best answer", | ||
| ); | ||
| return ""; | ||
| } |
There was a problem hiding this comment.
On the other hand: Having tests before fixing strict type things would give us confidence that it is still working (as expected).
MadLittleMods
commented
Nov 9, 2022
MadLittleMods
commented
Nov 10, 2022
| const winCount = Math.max(...votes.values()); | ||
| const userId = this.context.getUserId(); | ||
| const myVote = userVotes?.get(userId)?.answers[0]; | ||
| const myVote = userVotes?.get(userId!)?.answers[0]; |
There was a problem hiding this comment.
We can use ! here because a Map lookup with null or undefined will still give an undefined myVote which is acceptable in the logic below.
3 tasks
…m:matrix-org/matrix-react-sdk into madlittlemods/strict-getRelationsForEvent
MadLittleMods
requested review from
turt2live
and removed request for
t3chguy
turt2live
approved these changes
Nov 22, 2022
|
Thanks for the review @weeman1337 and merge @turt2live 🐾 |
amywalkerdev
pushed a commit
that referenced
this pull request
Nov 28, 2022
* Fix getRelationsForEvent tsc strictness * Use shared type for GetRelationsForEvent * Fix lint * Add alternative type * getRelationsForEvent is not required * Relations are optional * Reactions are optional * We expect relations in these tests * Add more protection if the eventID is not defined * Allow null too * Better test typing * User ID is not necessary unless something is selected * It's okay to [].includes(null) * Null is as good as undefined here * Null or undefined is good here * We have some expectations for the tests * The room and user can be undefined too * Protec * Reactions are optional * Try match signatures * Null or undefined * More null or undefined * Protec * Fix typo (wrong variable) * Remove optional params See #9558 (comment) * Fix up last maaaaybe relevant lint Co-authored-by: Michael Telatynski <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
getRelationsForEventunder TypeScriptstrictmodeSpawning from an unrelated spot that I got yelled at for in #8354. There is too much to fix to include in that PR if we want to get that right:
Checklist
Sign-off given on the changes (see CONTRIBUTING.md)This change is marked as an internal change (Task), so will not be included in the changelog.