refactor(oauth): Remove OAuthRegistrationStore and issuer
#4879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4879 +/- ##
==========================================
- Coverage 86.56% 86.54% -0.02%
==========================================
Files 300 299 -1
Lines 34985 34925 -60
==========================================
- Hits 30284 30226 -58
+ Misses 4701 4699 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zecakeh
changed the title
OAuthRegistrationStoreOAuthRegistrationStore and issuer
|
I added another commit that also removes the |
zecakeh
force-pushed
the
rm-registration-store
branch
from
df7706f to
7a32728
Compare
stefanceriu
approved these changes
Apr 3, 2025
MSC2966 was updated, clients should re-register for every log in, so we don't need to store the client IDs between logins. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
It is actually unused, and now that we only need homeserver URLs for static registrations, users don't need to access it easily. Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
force-pushed
the
rm-registration-store
branch
from
7a32728 to
a18d511
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSC2966 was updated pre-FCP (matrix-org/matrix-spec-proposals#2966 (comment)), clients should re-register for every login, so we don't need to store the client IDs between logins.