-
Notifications
You must be signed in to change notification settings - Fork 368
chore(cargo): Update rand to 0.9, and getrandom to 0.3.2
#4885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm afraid that this will have to wait for matrix-org/vodozemac#206 and its deps. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4885 +/- ##
==========================================
- Coverage 85.82% 85.81% -0.02%
==========================================
Files 299 299
Lines 35233 35235 +2
==========================================
- Hits 30239 30236 -3
- Misses 4994 4999 +5 ☔ View full report in Codecov by Sentry. |
This patch updates `rand` to 0.9. It brings several nice advantages: - it is compatible with the new Rust edition 2024, - it simplifies several signatures since `try_fill` is replaced by `fill`, there is no failure.
This patch deduplicates `getrandom` where it was present in 2 versions. It also updates `getrandom` to 0.3.2.
|
Why?
|
rand to 0.9rand to 0.9, and getrandom to 0.3.2
|
We have 2 versions of
We have to move many crates… |
|
Let's close this for now. We're going to collect merge conflicts for quite a bit here otherwise. |
This patch updates
randto 0.9. It brings several nice advantages:try_fillis replaced byfill, there is no failure, thus removing manyunwraps!This patch also updates
getrandomto 0.3.2 and improvestesting with Wasm and
getrandom.Based on chore(cargo): Updateeyeballandimbl#4884