Skip to content

refactor(timeline): Make RoomDataProvider provide Decryptor to simplify redecryption #5517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025

Conversation

andybalaam
Copy link
Member

Part of the work on #5474

This should help us (in future changes) to call into the decryptor thread from code that adds events to the timeline.

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (a9ce1c6) to head (2d02de1).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5517   +/-   ##
=======================================
  Coverage   88.57%   88.57%           
=======================================
  Files         340      340           
  Lines       93694    93665   -29     
  Branches    93694    93665   -29     
=======================================
- Hits        82989    82964   -25     
+ Misses       6573     6571    -2     
+ Partials     4132     4130    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Aug 12, 2025

CodSpeed Performance Report

Merging #5517 will not alter performance

Comparing andybalaam/hold-decryptor-in-timelinecontroller (2d02de1) with main (a9ce1c6)

Summary

✅ 31 untouched benchmarks

@andybalaam andybalaam force-pushed the andybalaam/hold-decryptor-in-timelinecontroller branch from 29e5824 to 40df8dc Compare August 12, 2025 14:41
@andybalaam andybalaam changed the title refactor(timeline): Hold a Decryptor inside TimelineController instead of passing it in when needed Make RoomDataProvider provide Decryptor to simplify redecryption Aug 12, 2025
@andybalaam andybalaam marked this pull request as ready for review August 12, 2025 14:44
@andybalaam andybalaam requested a review from a team as a code owner August 12, 2025 14:44
@andybalaam andybalaam requested review from bnjbvr and removed request for a team August 12, 2025 14:44
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

This is just a refactor, with no changes in behavior, at this point, right?

Can you tweak the PR name so that it also follows the commit message convention, please?

@andybalaam andybalaam changed the title Make RoomDataProvider provide Decryptor to simplify redecryption refactor(timeline): Make RoomDataProvider provide Decryptor to simplify redecryption Aug 13, 2025
@andybalaam
Copy link
Member Author

This is just a refactor, with no changes in behavior, at this point, right?

Yes

Can you tweak the PR name so that it also follows the commit message convention, please?

Done, thanks.

@andybalaam andybalaam force-pushed the andybalaam/hold-decryptor-in-timelinecontroller branch from 948012d to 2d02de1 Compare August 13, 2025 11:23
@andybalaam andybalaam enabled auto-merge (rebase) August 13, 2025 11:23
@andybalaam andybalaam merged commit 01059ef into main Aug 13, 2025
56 of 57 checks passed
@andybalaam andybalaam deleted the andybalaam/hold-decryptor-in-timelinecontroller branch August 13, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants