-
Notifications
You must be signed in to change notification settings - Fork 324
refactor(timeline): Make RoomDataProvider provide Decryptor to simplify redecryption #5517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(timeline): Make RoomDataProvider provide Decryptor to simplify redecryption #5517
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5517 +/- ##
=======================================
Coverage 88.57% 88.57%
=======================================
Files 340 340
Lines 93694 93665 -29
Branches 93694 93665 -29
=======================================
- Hits 82989 82964 -25
+ Misses 6573 6571 -2
+ Partials 4132 4130 -2 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5517 will not alter performanceComparing Summary
|
29e5824
to
40df8dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This is just a refactor, with no changes in behavior, at this point, right?
Can you tweak the PR name so that it also follows the commit message convention, please?
Yes
Done, thanks. |
948012d
to
2d02de1
Compare
Part of the work on #5474
This should help us (in future changes) to call into the decryptor thread from code that adds events to the timeline.