Skip to content

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Aug 12, 2025

This adds a manual thread subscription when a user is replying to a thread, via the send queue, according to the semantics of MSC4306.

Probably needs some kind of centralized mechanism to automatically subscribe when sending a message in the send queue, for both the send queue and the event cache.

Part of #4869.

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 84.86842% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.56%. Comparing base (e2f0b4f) to head (ed250ba).
⚠️ Report is 34 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/event_cache/room/threads.rs 80.70% 7 Missing and 4 partials ⚠️
crates/matrix-sdk/src/event_cache/room/mod.rs 84.21% 2 Missing and 4 partials ⚠️
crates/matrix-sdk/src/send_queue/mod.rs 75.00% 3 Missing and 1 partial ⚠️
crates/matrix-sdk-common/src/serde_helpers.rs 85.71% 0 Missing and 1 partial ⚠️
crates/matrix-sdk/src/room/mod.rs 95.65% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5520      +/-   ##
==========================================
- Coverage   88.56%   88.56%   -0.01%     
==========================================
  Files         340      340              
  Lines       93659    93784     +125     
  Branches    93659    93784     +125     
==========================================
+ Hits        82951    83061     +110     
- Misses       6574     6583       +9     
- Partials     4134     4140       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Aug 12, 2025

CodSpeed Performance Report

Merging #5520 will not alter performance

Comparing bnjbvr/auto-sub-send (ed250ba) with main (e2f0b4f)

Summary

✅ 31 untouched benchmarks

@bnjbvr
Copy link
Member Author

bnjbvr commented Aug 14, 2025

Fold in the other PR

@bnjbvr bnjbvr closed this Aug 14, 2025
@bnjbvr bnjbvr deleted the bnjbvr/auto-sub-send branch August 14, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant