-
Notifications
You must be signed in to change notification settings - Fork 323
feat(test): add a test utils crate to make log initialization possible everywhere #5521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test): add a test utils crate to make log initialization possible everywhere #5521
Conversation
CodSpeed Performance ReportMerging #5521 will not alter performanceComparing Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5521 +/- ##
=======================================
Coverage 88.56% 88.57%
=======================================
Files 340 340
Lines 93694 93694
Branches 93694 93694
=======================================
+ Hits 82982 82988 +6
+ Misses 6579 6573 -6
Partials 4133 4133 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, thanks! Can you also invoke the macro in matrix_sdk_common
, to prove that it addresses the issue, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think we'll also need to add it to the release scripts. Will push to your branch if I can
This PR allows
init_tracing_for_test
to be called by any other crate in the sdkSigned-off-by: multi [email protected]
Fixes #5292