Part 2 of Split media store from event cache store #5569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonfly1033
force-pushed
the
dragonfly1033/split_media_db_2
branch
from
10bcf5c to
745891b
Compare
8 tasks
dragonfly1033
force-pushed
the
dragonfly1033/split_media_db
branch
from
561c12e to
cef5dd3
Compare
dragonfly1033
force-pushed
the
dragonfly1033/split_media_db_2
branch
from
745891b to
79160d6
Compare
dragonfly1033
requested review from
bnjbvr and
Hywan
and removed request for
a team and
bnjbvr
Hywan
reviewed
Sep 2, 2025
crates/matrix-sdk-base/src/event_cache/store/media/integration_tests.rs
Outdated
Show resolved
Hide resolved
dragonfly1033
force-pushed
the
dragonfly1033/split_media_db
branch
from
cef5dd3 to
7d3c4ad
Compare
dragonfly1033
force-pushed
the
dragonfly1033/split_media_db_2
branch
from
79160d6 to
aa0cf8b
Compare
added 2 commits
September 3, 2025 12:54
Split `MemoryMediaStore` from `MemoryStore`. Split `IndexeddbMediaStore` from `IndexxeddbEventCacheStore`.
dragonfly1033
force-pushed
the
dragonfly1033/split_media_db
branch
from
7d3c4ad to
11fc140
Compare
dragonfly1033
force-pushed
the
dragonfly1033/split_media_db_2
branch
from
aa0cf8b to
2f5de97
Compare
Hywan
approved these changes
Sep 3, 2025
Part 3 of Split media store from event cache store
dragonfly1033
added a commit
that referenced
this pull request
Sep 3, 2025
Part 2 of Split media store from event cache store
dragonfly1033
added a commit
that referenced
this pull request
Sep 3, 2025
Part 2 of Split media store from event cache store
dragonfly1033
pushed a commit
that referenced
this pull request
Sep 3, 2025
CodSpeed Performance ReportMerging #5569 will not alter performanceComparing Summary
Footnotes |
dragonfly1033
pushed a commit
that referenced
this pull request
Sep 3, 2025
dragonfly1033
pushed a commit
that referenced
this pull request
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read #5568 . This is part 2.
Contains:
SqliteMediaStorefromSqliteEventCacheStore.MemoryMediaStorefromMemoryStore.IndexeddbMediaStorefromIndexxeddbEventCacheStore.Reminder for my own sanity:
Do not merge until part 3 #5571 is merged.
Signed-off-by: Shrey Patel [email protected]