Skip to content

refactor(base): Rename sync_lock to state_store_lock - #5707

Merged
Hywan merged 2 commits into
matrix-org:mainfrom
Hywan:refactor-sdk-rename-sync-lock
Sep 24, 2025
Merged

refactor(base): Rename sync_lock to state_store_lock#5707
Hywan merged 2 commits into
matrix-org:mainfrom
Hywan:refactor-sdk-rename-sync-lock

Conversation

@Hywan

@Hywan Hywan commented Sep 24, 2025

Copy link
Copy Markdown
Member

This patch renames the sync_lock to state_store_lock because it is what it is. It's not about the sync, it's about the state store.

This patch renames the `sync_lock` to `state_store_lock` because it is
what it is. It's not about the sync, it's about the state store.
@Hywan
Hywan marked this pull request as ready for review September 24, 2025 13:45
@Hywan
Hywan requested a review from a team as a code owner September 24, 2025 13:45
@Hywan
Hywan requested review from andybalaam and removed request for a team September 24, 2025 13:45

@bnjbvr bnjbvr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sync this is great!

@bnjbvr
bnjbvr removed the request for review from andybalaam September 24, 2025 13:51
@Hywan

Hywan commented Sep 24, 2025

Copy link
Copy Markdown
Member Author

You mean “I state_store_lock this is great”?

@Hywan
Hywan enabled auto-merge (rebase) September 24, 2025 13:53
@codecov

codecov Bot commented Sep 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.38%. Comparing base (688eb68) to head (48956cc).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5707   +/-   ##
=======================================
  Coverage   88.38%   88.38%           
=======================================
  Files         358      358           
  Lines       98939    98940    +1     
  Branches    98939    98940    +1     
=======================================
+ Hits        87451    87453    +2     
+ Misses       7352     7350    -2     
- Partials     4136     4137    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hywan
Hywan merged commit 290f27a into matrix-org:main Sep 24, 2025
59 of 60 checks passed
@codspeed-hq

codspeed-hq Bot commented Sep 24, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #5707 will not alter performance

Comparing Hywan:refactor-sdk-rename-sync-lock (3ca72c7) with main (688eb68)

Summary

✅ 50 untouched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants