feat: Append withheld info from room key bundle to store. #5737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylendog
force-pushed
the
kaylendog/shared-history/store
branch
from
8ae8fcf to
e635219
Compare
CodSpeed Performance ReportMerging #5737 will not alter performanceComparing Summary
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5737 +/- ##
==========================================
- Coverage 88.40% 88.39% -0.02%
==========================================
Files 359 359
Lines 99048 99234 +186
Branches 99048 99234 +186
==========================================
+ Hits 87566 87714 +148
- Misses 7344 7380 +36
- Partials 4138 4140 +2 ☔ View full report in Codecov by Sentry. |
kaylendog
requested review from
richvdh and
stefanceriu
and removed request for
a team
kaylendog
force-pushed
the
kaylendog/shared-history/store
branch
from
24dcbf4 to
fd3943c
Compare
Tests that a to-device `m.room_key.withheld` event can be serialized (using JSON), then deserialized as a RoomKeyWithheldEntry. Ensures compatibility with exisiting store data.
richvdh
requested changes
Oct 3, 2025
- Adds helper methods on `MegolmV1AesSha2WithheldContent` to access room and session ID. - Splits session import logic to `import_room_key_bundle_sessions`. - Splits withheld info import logic to `import_room_key_bundle_withheld_info`.
kaylendog
commented
Oct 6, 2025
| "room_keys": [ | ||
| { | ||
| "algorithm": "m.megolm.v1.aes-sha2", | ||
| "algorithm": "[algorithm]", |
There was a problem hiding this comment.
Fixes tests when running with experimental-algorithms feature enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Skye Elliot