Test alternate storage types for Ruma identifiers#6187
Draft
zecakeh wants to merge 8 commits intomatrix-org:mainfrom
Draft
Test alternate storage types for Ruma identifiers#6187zecakeh wants to merge 8 commits intomatrix-org:mainfrom
zecakeh wants to merge 8 commits intomatrix-org:mainfrom
Conversation
Arc storage type for Ruma identifiers
Arc storage type for Ruma identifiers
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6187 +/- ##
==========================================
- Coverage 89.85% 89.84% -0.01%
==========================================
Files 365 365
Lines 100845 100845
Branches 100845 100845
==========================================
- Hits 90613 90609 -4
- Misses 6696 6700 +4
Partials 3536 3536 ☔ View full report in Codecov by Sentry. |
5da1159 to
0be9700
Compare
0867c87 to
b8325bb
Compare
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
4f43bf7 to
f9d1d1b
Compare
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Comment on lines
+94
to
107
| - name: Run the benchmarks in simulation mode | ||
| uses: CodSpeedHQ/action@2ac572851726409c88c02a307f1ea2632a9ea59b | ||
| with: | ||
| run: cargo codspeed run | ||
| mode: "instrumentation" | ||
| mode: simulation | ||
| token: ${{ secrets.CODSPEED_TOKEN }} | ||
|
|
||
| - name: Run the benchmarks in memory mode | ||
| uses: CodSpeedHQ/action@2ac572851726409c88c02a307f1ea2632a9ea59b | ||
| if: ${{ matrix.benchmark != 'timeline' }} # The benchmark fails an assertion, maybe due to it being slower? | ||
| with: | ||
| run: cargo codspeed run | ||
| mode: memory | ||
| token: ${{ secrets.CODSPEED_TOKEN }} |
There was a problem hiding this comment.
Hey, co-founder of @CodSpeedHQ here.
Super glad to have using the memory instrument in addition to simulation.
One thing I recommend though is to use OIDC instead of tokens to authenticate the runs, it will be way faster and more secure 😉
You will need to add the following in your job/workflow:
permissions:
contents: read # required for actions/checkout
id-token: write # required for OIDC authentication with CodSpeedAnd you will no longer need the token: input of course:
Suggested change
| - name: Run the benchmarks in simulation mode | |
| uses: CodSpeedHQ/action@2ac572851726409c88c02a307f1ea2632a9ea59b | |
| with: | |
| run: cargo codspeed run | |
| mode: "instrumentation" | |
| mode: simulation | |
| token: ${{ secrets.CODSPEED_TOKEN }} | |
| - name: Run the benchmarks in memory mode | |
| uses: CodSpeedHQ/action@2ac572851726409c88c02a307f1ea2632a9ea59b | |
| if: ${{ matrix.benchmark != 'timeline' }} # The benchmark fails an assertion, maybe due to it being slower? | |
| with: | |
| run: cargo codspeed run | |
| mode: memory | |
| token: ${{ secrets.CODSPEED_TOKEN }} | |
| - name: Run the benchmarks in simulation mode | |
| uses: CodSpeedHQ/action@2ac572851726409c88c02a307f1ea2632a9ea59b | |
| with: | |
| run: cargo codspeed run | |
| mode: simulation | |
| - name: Run the benchmarks in memory mode | |
| uses: CodSpeedHQ/action@2ac572851726409c88c02a307f1ea2632a9ea59b | |
| if: ${{ matrix.benchmark != 'timeline' }} # The benchmark fails an assertion, maybe due to it being slower? | |
| with: | |
| run: cargo codspeed run | |
| mode: memory |
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
afcf61f to
57b8f58
Compare
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not meant to be merged, I want to see how much changing the inner type of
Owned*identifiers influences codspeed benchmarks.