feat(sdk): add high-level Search helpers + ffi bindings#6394
Open
feat(sdk): add high-level Search helpers + ffi bindings#6394
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6394 +/- ##
==========================================
+ Coverage 89.87% 89.88% +0.01%
==========================================
Files 378 379 +1
Lines 103457 103780 +323
Branches 103457 103780 +323
==========================================
+ Hits 92977 93282 +305
- Misses 6909 6919 +10
- Partials 3571 3579 +8 ☔ View full report in Codecov by Sentry. |
Merging this PR will improve performance by ×2.5
Performance Changes
Comparing |
6ed213a to
5f0244b
Compare
Member
Author
|
This PR is in a sufficiently good state that it would allow FFI embedders to try out the search feature, build a search UI and so on. Doesn't do automatic indexation of all content, that problem is currently left as an exercise to the reader/embedder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting to extract relevant helpers that can be merged ahead of having search spider all rooms in background.
Part of #5350.
CHANGELOG.mdfiles.