Skip to content

feat(sdk): add high-level Search helpers + ffi bindings#6394

Open
bnjbvr wants to merge 6 commits intomainfrom
bnjbvr/ui-search-iterators
Open

feat(sdk): add high-level Search helpers + ffi bindings#6394
bnjbvr wants to merge 6 commits intomainfrom
bnjbvr/ui-search-iterators

Conversation

@bnjbvr
Copy link
Copy Markdown
Member

@bnjbvr bnjbvr commented Apr 1, 2026

Starting to extract relevant helpers that can be merged ahead of having search spider all rooms in background.

Part of #5350.

  • I've documented the public API Changes in the appropriate CHANGELOG.md files.
  • This PR was made with the help of AI (autocomplete).

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 95.98765% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.88%. Comparing base (a1157d2) to head (2beab7b).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-ui/src/search/mod.rs 95.97% 5 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6394      +/-   ##
==========================================
+ Coverage   89.87%   89.88%   +0.01%     
==========================================
  Files         378      379       +1     
  Lines      103457   103780     +323     
  Branches   103457   103780     +323     
==========================================
+ Hits        92977    93282     +305     
- Misses       6909     6919      +10     
- Partials     3571     3579       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 1, 2026

Merging this PR will improve performance by ×2.5

⚡ 1 improved benchmark
✅ 49 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation Restore session [memory store] 276.5 ms 112.2 ms ×2.5

Comparing bnjbvr/ui-search-iterators (2beab7b) with main (a1157d2)

Open in CodSpeed

@bnjbvr bnjbvr force-pushed the bnjbvr/ui-search-iterators branch from 6ed213a to 5f0244b Compare April 2, 2026 11:22
@bnjbvr bnjbvr marked this pull request as ready for review April 2, 2026 11:22
@bnjbvr bnjbvr requested a review from a team as a code owner April 2, 2026 11:22
@bnjbvr bnjbvr requested review from stefanceriu and removed request for a team April 2, 2026 11:22
@bnjbvr
Copy link
Copy Markdown
Member Author

bnjbvr commented Apr 2, 2026

This PR is in a sufficiently good state that it would allow FFI embedders to try out the search feature, build a search UI and so on. Doesn't do automatic indexation of all content, that problem is currently left as an exercise to the reader/embedder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant