Skip to content

refactor(timeline): allow creating a TimelineItemContent from a sdk::TimelineEvent#6408

Merged
bnjbvr merged 1 commit intomainfrom
bnjbvr/timeline-item-content
Apr 2, 2026
Merged

refactor(timeline): allow creating a TimelineItemContent from a sdk::TimelineEvent#6408
bnjbvr merged 1 commit intomainfrom
bnjbvr/timeline-item-content

Conversation

@bnjbvr
Copy link
Copy Markdown
Member

@bnjbvr bnjbvr commented Apr 2, 2026

A small refactor extracted from the search PR, as it's actually useful to do ahead of time, since the code was already duplicated.

  • I've documented the public API Changes in the appropriate CHANGELOG.md files.
  • This PR was made with the help of AI.

@bnjbvr bnjbvr requested a review from a team as a code owner April 2, 2026 10:04
@bnjbvr bnjbvr requested review from a team, Hywan and andybalaam and removed request for a team and Hywan April 2, 2026 10:04
Copy link
Copy Markdown
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 84.31373% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.86%. Comparing base (32e9626) to head (2fe657b).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rates/matrix-sdk-ui/src/timeline/event_item/mod.rs 69.23% 3 Missing and 1 partial ⚠️
...trix-sdk-ui/src/timeline/event_item/content/mod.rs 88.46% 2 Missing and 1 partial ⚠️
crates/matrix-sdk-ui/src/timeline/latest_event.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6408      +/-   ##
==========================================
+ Coverage   89.85%   89.86%   +0.01%     
==========================================
  Files         378      378              
  Lines      103384   103345      -39     
  Branches   103384   103345      -39     
==========================================
- Hits        92893    92873      -20     
+ Misses       6928     6905      -23     
- Partials     3563     3567       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr bnjbvr force-pushed the bnjbvr/timeline-item-content branch from 7ff5909 to 2fe657b Compare April 2, 2026 10:19
@bnjbvr bnjbvr enabled auto-merge (rebase) April 2, 2026 10:23
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 2, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing bnjbvr/timeline-item-content (2fe657b) with main (32e9626)

Open in CodSpeed

@bnjbvr bnjbvr merged commit 7cea5be into main Apr 2, 2026
52 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/timeline-item-content branch April 2, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants