Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6409 +/- ##
==========================================
- Coverage 89.87% 89.85% -0.02%
==========================================
Files 378 378
Lines 103445 103445
Branches 103445 103445
==========================================
- Hits 92973 92953 -20
- Misses 6902 6915 +13
- Partials 3570 3577 +7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Note that the rustls-tls feature flag is temporarily left in place to keep other crates from breaking, but it becomes a trivial flag. It will be removed altogether in a later commit. Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
…re flag Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
1d8e94f to
ab83ed0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this pull request should be merged in conjunction with matrix-org/complement-crypto#236.
This pull request removes both the
native-tlsandrustls-tlsfeature flags in all crates where they exist. The resulting behavior is thatrustlsbecomes the only TLS backend, and no others can be selected.The benefit here is that
rustlssupports TLS v1.3 on all platforms, whereasnative-tlsdoes not (see #6053). Additionally, thenative-tlsandrustls-tlsfeature flags were not additive, but rather they were mutually exclusive. This is not an ideal property for feature flags.From The Cargo Book
Closes #6383.
CHANGELOG.mdfiles.Signed-off-by: Michael Goldenberg m@mgoldenberg.net