Support stable prefix for MSC4287 m.key_backup#6410
Open
andybalaam wants to merge 1 commit intomainfrom
Open
Conversation
andybalaam
force-pushed
the
andybalaam/msc4287-add-stable-prefix
branch
from
1ce8c09 to
45fdbc5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6410 +/- ##
==========================================
- Coverage 89.87% 89.86% -0.02%
==========================================
Files 378 378
Lines 103445 103449 +4
Branches 103445 103449 +4
==========================================
- Hits 92973 92965 -8
- Misses 6902 6913 +11
- Partials 3570 3571 +1 ☔ View full report in Codecov by Sentry. |
poljar
requested changes
Apr 3, 2026
Contributor
poljar
left a comment
poljar
left a comment
There was a problem hiding this comment.
Ah, thanks for speccing this and tackling it in the SDK.
The event should probably go into Ruma, looks good otherwise.
| /// | ||
| /// [MSC4287]: https://github.com/matrix-org/matrix-spec-proposals/pull/4287 | ||
| #[derive(Clone, Debug, Default, Deserialize, Serialize, EventContent)] | ||
| #[ruma_event(type = "m.key_backup", kind = GlobalAccountData)] |
Contributor
There was a problem hiding this comment.
I think the stable type should now live in Ruma.
| /// Unstable prefix form of [MSC4287]. | ||
| /// | ||
| /// [MSC4287]: https://github.com/matrix-org/matrix-spec-proposals/pull/4287 | ||
| #[derive(Clone, Debug, Default, Deserialize, Serialize, EventContent)] |
Contributor
There was a problem hiding this comment.
We can keep this one around for a while.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the unstable prefix up-to-date for now, so clients have time to migrate.
CHANGELOG.mdfiles.