feat: expose call_intent for m.rtc.notification#6412
Open
Susurrus wants to merge 1 commit intomatrix-org:mainfrom
Open
feat: expose call_intent for m.rtc.notification#6412Susurrus wants to merge 1 commit intomatrix-org:mainfrom
Susurrus wants to merge 1 commit intomatrix-org:mainfrom
Conversation
This allows for notifications to use the intent for deciding how to render the message (e.g. whether to call it a "call" or a "video call"). Signed-off-by: Bryant Mairs <bryant@mai.rs>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6412 +/- ##
==========================================
- Coverage 89.87% 89.87% -0.01%
==========================================
Files 378 378
Lines 103445 103446 +1
Branches 103445 103446 +1
==========================================
- Hits 92973 92968 -5
- Misses 6902 6909 +7
+ Partials 3570 3569 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for notifications to use the intent for deciding how to render the message (e.g. whether to call it a "call" or a "video call"). MSC4075 specifically states these shouldn't be used for rendering in the timeline, but I'm not exactly clear why (discussion link). We'd like to use it in Fractal in lieu for now of having the membership-based call rendering, which AFAIK isn't implemented here yet. So adding this field here would be useful.
This field is also not technically in the spec (I added a comment about it), but since it's elsewhere in the SDK, figured it was fine to expose it here as well.
I left out other fields, tho there are several, as I'm not certain why these fields weren't originally exposed and didn't want to complicate things here too much.
CHANGELOG.mdfiles.