Skip to content

feat: expose call_intent for m.rtc.notification#6412

Open
Susurrus wants to merge 1 commit intomatrix-org:mainfrom
Susurrus:call_intent
Open

feat: expose call_intent for m.rtc.notification#6412
Susurrus wants to merge 1 commit intomatrix-org:mainfrom
Susurrus:call_intent

Conversation

@Susurrus
Copy link
Copy Markdown
Contributor

@Susurrus Susurrus commented Apr 5, 2026

This allows for notifications to use the intent for deciding how to render the message (e.g. whether to call it a "call" or a "video call"). MSC4075 specifically states these shouldn't be used for rendering in the timeline, but I'm not exactly clear why (discussion link). We'd like to use it in Fractal in lieu for now of having the membership-based call rendering, which AFAIK isn't implemented here yet. So adding this field here would be useful.

This field is also not technically in the spec (I added a comment about it), but since it's elsewhere in the SDK, figured it was fine to expose it here as well.

I left out other fields, tho there are several, as I'm not certain why these fields weren't originally exposed and didn't want to complicate things here too much.

  • I've documented the public API Changes in the appropriate CHANGELOG.md files.
  • This PR was made with the help of AI.

@Susurrus Susurrus requested a review from a team as a code owner April 5, 2026 11:36
@Susurrus Susurrus requested review from poljar and removed request for a team April 5, 2026 11:36
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 5, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing Susurrus:call_intent (8e2453a) with main (a65fec3)

Open in CodSpeed

This allows for notifications to use the intent for deciding how to
render the message (e.g. whether to call it a "call" or a "video call").

Signed-off-by: Bryant Mairs <bryant@mai.rs>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.87%. Comparing base (a65fec3) to head (8e2453a).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-ui/src/timeline/event_handler.rs 0.00% 2 Missing ⚠️
...trix-sdk-ui/src/timeline/event_item/content/mod.rs 0.00% 2 Missing ⚠️
...rates/matrix-sdk-ui/src/timeline/event_item/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6412      +/-   ##
==========================================
- Coverage   89.87%   89.87%   -0.01%     
==========================================
  Files         378      378              
  Lines      103445   103446       +1     
  Branches   103445   103446       +1     
==========================================
- Hits        92973    92968       -5     
- Misses       6902     6909       +7     
+ Partials     3570     3569       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant