Skip to content

feat: add room versions to HomeserverCapabilities#6413

Merged
bnjbvr merged 1 commit intomatrix-org:mainfrom
Susurrus:room_versions
Apr 8, 2026
Merged

feat: add room versions to HomeserverCapabilities#6413
bnjbvr merged 1 commit intomatrix-org:mainfrom
Susurrus:room_versions

Conversation

@Susurrus
Copy link
Copy Markdown
Contributor

@Susurrus Susurrus commented Apr 5, 2026

Expose room versions as well, which weren't originally included in !6371. I'm not clear why, but this is used by Fractal, so updating to the newest SDK is a bit annoying without this. See https://gitlab.gnome.org/World/fractal/-/merge_requests/2168 for the code changes for that upgrade.

I think this can reuse the existing CHANGELOG entry since it's not super specific.

  • I've documented the public API Changes in the appropriate CHANGELOG.md files.
  • This PR was made with the help of AI.

@Susurrus Susurrus requested a review from a team as a code owner April 5, 2026 11:44
@Susurrus Susurrus requested review from bnjbvr and removed request for a team April 5, 2026 11:44
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2026

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.81%. Comparing base (1f3dea7) to head (cfa54fc).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/matrix-sdk/src/client/homeserver_capabilities.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6413      +/-   ##
==========================================
- Coverage   89.85%   89.81%   -0.05%     
==========================================
  Files         378      378              
  Lines      103777   103785       +8     
  Branches   103777   103785       +8     
==========================================
- Hits        93248    93212      -36     
- Misses       6957     6984      +27     
- Partials     3572     3589      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 5, 2026

Merging this PR will degrade performance by 49.83%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 49 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation Restore session [memory store] 111.7 ms 222.6 ms -49.83%

Comparing Susurrus:room_versions (39f48f4) with main (1f3dea7)

Open in CodSpeed

Copy link
Copy Markdown
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a tiny comment around the changelog entry, and we should be good to go!

Add `m.room_versions` & `m.account_moderation` that were missed in the
first implementation.

Signed-off-by: Bryant Mairs <bryant@mai.rs>
Copy link
Copy Markdown
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bnjbvr bnjbvr merged commit 99a5568 into matrix-org:main Apr 8, 2026
52 checks passed
@Susurrus Susurrus deleted the room_versions branch April 8, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants