feat: add room versions to HomeserverCapabilities#6413
feat: add room versions to HomeserverCapabilities#6413bnjbvr merged 1 commit intomatrix-org:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6413 +/- ##
==========================================
- Coverage 89.85% 89.81% -0.05%
==========================================
Files 378 378
Lines 103777 103785 +8
Branches 103777 103785 +8
==========================================
- Hits 93248 93212 -36
- Misses 6957 6984 +27
- Partials 3572 3589 +17 ☔ View full report in Codecov by Sentry. |
Merging this PR will degrade performance by 49.83%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | Restore session [memory store] |
111.7 ms | 222.6 ms | -49.83% |
Comparing Susurrus:room_versions (39f48f4) with main (1f3dea7)
bnjbvr
left a comment
There was a problem hiding this comment.
Thanks! Just a tiny comment around the changelog entry, and we should be good to go!
Add `m.room_versions` & `m.account_moderation` that were missed in the first implementation. Signed-off-by: Bryant Mairs <bryant@mai.rs>
Expose room versions as well, which weren't originally included in !6371. I'm not clear why, but this is used by Fractal, so updating to the newest SDK is a bit annoying without this. See https://gitlab.gnome.org/World/fractal/-/merge_requests/2168 for the code changes for that upgrade.
I think this can reuse the existing CHANGELOG entry since it's not super specific.
CHANGELOG.mdfiles.