feat(ui): room_list_service::filters::unread becomes read_receipts - #6928
Merged
Hywan merged 4 commits intoAug 27, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6928 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01%
==========================================
Files 407 407
Lines 115985 115968 -17
Branches 115985 115968 -17
==========================================
- Hits 104532 104506 -26
- Misses 7535 7536 +1
- Partials 3918 3926 +8 ☔ View full report in Codecov by Harness. |
Hywan
force-pushed
the
feat-ui-room-list-filter-read-receipts
branch
from
August 27, 2026 08:18
6a78c42 to
dedf9e7
Compare
2 tasks
Hywan
force-pushed
the
feat-ui-room-list-filter-read-receipts
branch
from
August 27, 2026 08:31
dedf9e7 to
eaf81db
Compare
Hywan
marked this pull request as ready for review
August 27, 2026 08:32
Hywan
force-pushed
the
feat-ui-room-list-filter-read-receipts
branch
4 times, most recently
from
August 27, 2026 08:56
be4cf2a to
d1adc71
Compare
poljar
approved these changes
Aug 27, 2026
poljar
left a comment
Contributor
There was a problem hiding this comment.
I left a couple of nits, looks good otherwise.
Hywan
force-pushed
the
feat-ui-room-list-filter-read-receipts
branch
from
August 27, 2026 12:20
d1adc71 to
75f9975
Compare
This patch renames the `room_list_service::filters::unread` filter to `read_receipts` and adds a new parameter: `ReadReceiptsCategory`. Before it was looking at the `ReadReceipts::num_notifications` field only, now it can look at the following field: `num_mentions`, `num_notifications` or `num_messages`. The condition where `Room::is_marked_unread` makes the room to be selected if there is no unread is kept because (i) it's a manual operation from the user, (ii) it signals the room is unread but for an unknown reason, it could be anything, so it's important and should be displayed regardless of the number of unreads.
This patch updates the `matches` function of `room_list_service::filters` and `room_list_service::sorters` to take a `fn` instead of a `Fn`. This has the same effect with our current code except it's a bit faster to compile as there is no generic parameter. It also reduces the risk of having monomorphisation which could duplicate the code in the resulting binary.
Hywan
force-pushed
the
feat-ui-room-list-filter-read-receipts
branch
from
August 27, 2026 12:23
75f9975 to
6d140d5
Compare
Hywan
enabled auto-merge (rebase)
August 27, 2026 12:23
This patch removes the need to declare `RoomListFilterCategory` and `RoomListFilterReadReceipts` in `matrix-sdk-ffi` by directly declaring the bindings in `matrix-sdk-ui`.
Hywan
force-pushed
the
feat-ui-room-list-filter-read-receipts
branch
from
August 27, 2026 12:34
6d140d5 to
fe800e4
Compare
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch renames the
room_list_service::filters::unreadfilter toread_receiptsand adds a new parameter:ReadReceiptsCategory. Before it was looking at theReadReceipts::num_notificationsfield only, now it can look at the following field:num_mentions,num_notificationsornum_messages.The condition where
Room::is_marked_unreadmakes the room to be selected if there is no unread is kept because (i) it's a manual operation from the user, (ii) it signals the room is unread but for an unknown reason, it could be anything, so it's important and should be displayed regardless of the number of unread.Before:
After:
It is admittedly a bit longer but it unlocks more flexibility and more features.
Signed-off-by: