-
Notifications
You must be signed in to change notification settings - Fork 413
MSC3288: Add room type to /_matrix/identity/v2/store-invite API
#3288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
7f8f9e1
2827cb6
814a86d
80c7ed7
b361ef6
e267d74
4f03722
cb93e5d
9434aba
e358df1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # MSC3288: Make email invites space aware | ||
BillCarsonFr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| Currently when inviting via 3pid, the Identity Server is getting some information about the room, | ||
BillCarsonFr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| like for example the room name and avatar as well as the inviter name. | ||
| This allows the identity server to generate a rich email to the invitee. | ||
|
|
||
| Now that the matrix spec supports spaces, it would be nice to also provide this information to the identity server | ||
| so that the email invite could be customized for spaces, current implementation would say wrongly that | ||
BillCarsonFr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| you are invited to a room when the room is actually a space. | ||
|
|
||
| The goal of this proposal is to make 3pid invites space aware. | ||
|
|
||
|
|
||
| ## Proposal | ||
|
|
||
| Home servers should also send the `room_type` to the identity server when performing a third party invite (__Invitation storage__). | ||
BillCarsonFr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
|
|
||
| __Proposed change:__ | ||
|
|
||
| Add a new `room_type` field in json body of `POST /_matrix/identity/v2/store-invite` | ||
BillCarsonFr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| | Parameter | Type | Description | | ||
| |--|--|--| | ||
| | room_type | string | The room type for the room to which the user is invited. This should be retrieved from the value of `type` in `m.room.create` event. Do not include paremeter if not `type` not present in `m.room.create`. | ||
BillCarsonFr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ```` | ||
| POST /_matrix/identity/v2/store-invite HTTP/1.1 | ||
| Content-Type: application/json | ||
|
|
||
| { | ||
| "medium": "email", | ||
| "address": "[email protected]", | ||
| "room_id": "!something:example.org", | ||
| "sender": "@bob:example.com", | ||
| "room_alias": "#somewhere:exmaple.org", | ||
| "room_avatar_url": "mxc://example.org/s0meM3dia", | ||
| "room_join_rules": "public", | ||
| "room_name": "The Bob Project", | ||
| "room_type": "m.space", | ||
| "sender_display_name": "Bob Smith", | ||
| "sender_avatar_url": "mxc://example.org/an0th3rM3dia" | ||
| } | ||
| ```` | ||
|
|
||
| The identity server could then use room type to customize the email depending on the room type. | ||
|
|
||
| __Email Generation__ | ||
|
|
||
| The link in the generated email should also pass over the `room_type` to clients ( like it is doing for | ||
| `inviter_name`, `room_name`, `room_avatar`) | ||
|
Comment on lines
+50
to
+51
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think any of this bit is specced currently... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should I create a new PR to add them to the spec? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the intent of this MSC is clear enough. Would count the missing three as a spec omission. |
||
|
|
||
| ## Potential issues | ||
|
|
||
| None. | ||
|
|
||
|
|
||
| ## Security considerations | ||
|
|
||
| None. | ||
BillCarsonFr marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ## Unstable prefix | ||
|
|
||
| The following mapping will be used for identifiers in this MSC during development: | ||
|
|
||
|
|
||
| Proposed final identifier | Purpose | Development identifier | ||
| ------------------------------- | ------- | ---- | ||
| `room_type` | POST body | `org.matrix.msc3288.room_type` | ||
Uh oh!
There was an error while loading. Please reload this page.