-
Notifications
You must be signed in to change notification settings - Fork 412
MSC3817: Allow widgets to create rooms #3817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dhenneke
wants to merge
2
commits into
matrix-org:main
Choose a base branch
from
nordeck:nic/feat/widgetapi-create-room
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,149 @@ | ||
| # MSC3817: Allowing widgets to create rooms | ||
|
|
||
| [MSC1236](https://github.com/matrix-org/matrix-doc/issues/1236) and (among others) | ||
| [MSC2763](https://github.com/matrix-org/matrix-spec-proposals/pull/2762) specify a Widget API that | ||
| is able to send events to the client and receive events from the client. One feature that is not yet | ||
| available is the creation of new rooms via this API. An example use case for this feature is a | ||
| calendar application that can create new Matrix rooms for every calendar event. Another is a widget | ||
| that allows the user to create breakout rooms to discuss certain topics directly from the widget. | ||
| Giving the widget this option would also give them the possibility to provide an initial state for | ||
| the room that is hard (or impossible) to add after the room has been created. | ||
|
|
||
| This proposal aims to bring the functionality of creating rooms into the widget specification. It | ||
| should provide the same features that the | ||
| [“Room Creation” endpoint](https://spec.matrix.org/v1.2/client-server-api/#creation) of the | ||
| Client-Server API provides. | ||
|
|
||
| ## Proposal | ||
|
|
||
| Having the possibility to create new rooms would improve the capabilities of the widgets and would | ||
| fill a gap of widget room capabilities. As of now, a widget can read and write state or room events | ||
| to arbitrary rooms, but it can't be used to create these rooms. | ||
|
|
||
| In order to secure the user from malicious widgets, we will add a new capability that the user must | ||
| manually approve: | ||
|
|
||
| - `m.create_room`: Let the widget create new rooms. | ||
|
|
||
| This capability will enable the user to provide arbitrary events as the initial state of the room and | ||
| can also invite an arbitrary amount of users to the room. These events are not bound by the approved | ||
| capabilities of the widget, because we assume that the creator of the room should be able to have the | ||
| full control of the room during this initialization process. Thus, the `m.send.event:<event type>` | ||
| capabilities will not apply here. | ||
|
|
||
| To trigger the action, widgets will use a new `fromWidget` request with the action `create_room` which | ||
| takes the following shape: | ||
|
|
||
| ```json | ||
| { | ||
| "api": "fromWidget", | ||
| "widgetId": "20200827_WidgetExample", | ||
| "requestid": "generated-id-1234", | ||
| "action": "create_room", | ||
| "data": { | ||
| "creation_content": { | ||
| "m.federate": false | ||
| }, | ||
| "initial_state": [], | ||
| "invite": [], | ||
| "invite_3pid": [], | ||
| "is_direct": false, | ||
| "name": "The Grand Duke Pub", | ||
| "power_level_content_override": {}, | ||
| "preset": "public_chat", | ||
| "room_alias_name": "thepub", | ||
| "room_version": "1", | ||
| "topic": "All about happy hour", | ||
| "visibility": "public" | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| Under `data`, all keys are a mirrored representation of the original `/createRoom` API. This also | ||
| means that all keys are optional. | ||
|
|
||
| If the widget did not get approved for the capability required to send the event, the client MUST | ||
| send an error response (as required currently by the capabilities system for widgets). | ||
|
|
||
| The client SHOULD NOT modify the data of the request. The widget is responsible for producing valid | ||
| events - the client MUST pass through any errors, such as permission errors, to the widget using the | ||
| standard error response in the Widget API. | ||
|
|
||
| If the event is successfully sent by the client, the client sends the following response: | ||
|
|
||
| ```json | ||
| { | ||
| "api": "fromWidget", | ||
| "widgetId": "20200827_WidgetExample", | ||
| "requestid": "generated-id-1234", | ||
| "action": "create_room", | ||
| "data": { | ||
| "creation_content": { | ||
| "m.federate": false | ||
| }, | ||
| "initial_state": [], | ||
| "invite": [], | ||
| "invite_3pid": [], | ||
| "is_direct": false, | ||
| "name": "The Grand Duke Pub", | ||
| "power_level_content_override": {}, | ||
| "preset": "public_chat", | ||
| "room_alias_name": "thepub", | ||
| "room_version": "1", | ||
| "topic": "All about happy hour", | ||
| "visibility": "public" | ||
| }, | ||
| "response": { | ||
| "room_id": "!room:example.org" | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| The `room_id` field of the `response` is required and represents the ID of the new room that has been | ||
| created. | ||
|
|
||
| ## Alternatives | ||
|
|
||
| Widgets could be powered by a bot or some sort of backend which allows them to create new rooms, | ||
| however this can be a large amount of infrastructure for a widget to maintain. The widget is already | ||
| capable of interacting with the events that are stored in a room, so the sole purpose of the bot | ||
| would be to create new rooms. | ||
|
|
||
| The Widget API could limit the API surface by not permitting the widget to e.g. provide an initial | ||
| state or by providing user ids that should be invited by the server. However, this would limit the | ||
| usefulness of the API. | ||
|
|
||
| If [MSC3008](https://github.com/matrix-org/matrix-spec-proposals/pull/3008) goes forward, the widget | ||
| could interact with the respective API call of the Client-Server API. However, the status of the MSC | ||
| is unknown so it would be a good alternative to add this feature to the widget API. | ||
|
|
||
| Instead of mirroring the API surface of the Client-Server API, the widget api could use a more | ||
| specific interface as it is also available in the | ||
| [`matrix-react-sdk`](https://github.com/matrix-org/matrix-react-sdk/blob/c67b41fbde06e302e0ca296d99fbcea9f95b4a78/src/createRoom.ts#L52-L67) | ||
| and provide that in the `WidgetDriver` interface. This would enable the API to for example automatically | ||
| setup the encryption or add the `m.space.child` to a parent space room. However, the Widget API is | ||
| more independent if it doesn't rely on external logic, especially considering a potential emergence | ||
| of MSC3008. This also means that this complexity is moved to the widget itself that must implement | ||
| the logic if needed. | ||
|
|
||
| ## Security considerations | ||
|
|
||
| It is important that clients prompt for permission to create rooms. It could mess with the room list | ||
| of a user, or it could also invite unwanted users to a room. This could either be a malicious bot, | ||
| or other users who are spammed with unwanted invitations. Instead of solely relying on the | ||
| `m.create_room` capability, the widget API could consider the `m.send.event:<event type>` capabilities | ||
| for all events that are provided as initial state in the API call. This could also include the | ||
| `m.send.event:m.room.member` capability to secure the `invite` list. But in order to correctly check | ||
| the capabilities, the widget would need to have the capabilities accepted for the `room_id` of the | ||
| room that is about to be created, or the widget must request timeline access to all (i.e. `"*"`) | ||
| rooms, which would be unpractical. An alternative could be to add more narrowly scoped capabilities | ||
| such as `m.create_room:invite,m.room.encryption,…`. | ||
|
|
||
| ## Unstable prefix | ||
|
|
||
| While this MSC is not present in the spec, clients and widgets should: | ||
|
|
||
| - Use `org.matrix.msc3817.` in place of `m.` in all new identifiers of this MSC. | ||
| - Use `org.matrix.msc3817.create_room` in place of `create_room` for the action type in the | ||
| `fromWidget` requests. | ||
| - Only call/support the `action`s if an API version of `org.matrix.msc3817` is advertised. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any desire to require widgets to request the user's permission per room type that they'd like to create? For instance, I'd possibly be happy with a widget creating lots of
m.calendar.eventtype rooms, but less happy for it to have the ability to create Spaces.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that could be reasonable. There could be a
m.create_room(orm.create_room:?) capability to add a room without a type, andm.create_room:<room-type>for specific types. I'm not sure if there would be a use case for am.create_room:*capability. Say someone builds a generic room manager widget for some reason, it could also make use of MSC2974 to request that on demand.