Skip to content

Conversation

@tcpipuk
Copy link
Contributor

@tcpipuk tcpipuk commented Apr 19, 2024

@tcpipuk tcpipuk changed the title MSC0000: Extending User Profile API with Key:Value Pairs MSC4133: Extending User Profile API with Key:Value Pairs Apr 19, 2024
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Apr 19, 2024
@turt2live
Copy link
Member

@tcpipuk when you get a chance, please sign off on your changes to allow the MSC to eventually be eligible for acceptance.

@tcpipuk

This comment was marked as resolved.

@turt2live
Copy link
Member

Looks great, thanks!

@tcpipuk tcpipuk marked this pull request as ready for review April 19, 2024 19:46
@andrewzhurov
Copy link

Seems we discuss here a key-value CRDT, as keys would need to be updated over time. Personally, I'm all in favor.
With no regard be those events a part of a (messaging) Room or be in its own Profile Room (#1769) (which would be neat),
we need a mechanism to get the latest key-value pairs.

Matrix Event Graph is isomorphic to Merkle-CRDT that powers OrbitDB (key-value DB is one of the supported CRDT).
Taking an inspiration from how key-value CRDT works may be of help to spec it for those Servers wishing to opt-in.

@turt2live
Copy link
Member

I'm not sure how the bot will respond to this, but the SCT is resolving the outstanding concern on addressing the recent feedback. Under normal process, this would cause FCP to finish immediately, however it feels valuable for this MSC to have an opportunity for final thoughts to be raised.

FCP will resume until 15:00 UTC on Friday, January 31st, 2025.

@mscbot resolve Feedback during FCP needs consideration.

@mscbot mscbot removed the unresolved-concerns This proposal has at least one outstanding concern label Jan 30, 2025
@turt2live
Copy link
Member

The final comment period, with a disposition to merge, as per the review above, is now complete.

No it isn't

Now it is

@turt2live turt2live added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jan 31, 2025
@turt2live turt2live merged commit eb813af into matrix-org:main Jan 31, 2025
1 check passed
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jan 31, 2025
@tulir
Copy link
Member

tulir commented Feb 14, 2025

Spec PR: matrix-org/matrix-spec#2071

@tulir tulir added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Feb 14, 2025
Comment on lines +29 to +30
- Guest access follows the same rules as existing profile endpoints - guests may view profiles but
not modify them
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't fully correct -- guests can set only their display name. I'm assuming this implies that they can still modify their display name (Which for this MSC implies set & now delete), while other fields cannot be modified.

Copy link
Contributor Author

@tcpipuk tcpipuk Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, the intention was "We don't change what guests are allowed to do/access" 🙂

@richvdh richvdh added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Aug 12, 2025
@turt2live turt2live moved this from Requires spec PR review to Merged in Spec Core Team Workflow Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.