-
Notifications
You must be signed in to change notification settings - Fork 411
MSC4368: Combine definitions of M_RESOURCE_LIMIT_EXCEEDED error code and m.server_notice.usage_limit_reached server notice type #4368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hughns
wants to merge
2
commits into
main
Choose a base branch
from
hughns/resource-limit-exceeded-extra-fields
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−0
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
# MSC4368: Add limit_type to M_RESOURCE_LIMIT_EXCEEDED error code | ||
|
||
## Proposal | ||
|
||
1. Add an optional `limit_type` field to the body of the [`M_RESOURCE_LIMIT_EXCEEDED`] error response that has the same | ||
definition as it does for [`m.server_notice`]: | ||
|
||
> The kind of usage limit the server has exceeded | ||
And on the possible values: | ||
|
||
> The specified values for `limit_type` are: | ||
> `monthly_active_user` The server’s number of active users in the last 30 days has exceeded the maximum. New | ||
> connections are being refused by the server. What defines “active” is left as an implementation detail, however | ||
> servers are encouraged to treat syncing users as “active”. | ||
2. Update the description of `admin_contact` so that instead of "a place to reach out to" that it is the same definition | ||
as the `admin_contact` field on the [`m.server_notice`] which says "a URI giving a contact method for the server | ||
administrator". | ||
|
||
This amounts to unifying the representation of a server resource limit being exceeded in an error code and the server | ||
notice. | ||
|
||
## Potential issues | ||
|
||
None anticipated. Optional extra fields on the error. | ||
|
||
## Alternatives | ||
|
||
None considered. | ||
|
||
## Security considerations | ||
|
||
None. | ||
|
||
## Unstable prefix | ||
|
||
Ideally implementations would use an unstable prefix of something like `io.element.mscXXX.limit_type` whilst the | ||
MSC is in development. | ||
|
||
However, it is noted that the implementation in Synapse has existed since | ||
[2018](https://github.com/matrix-org/synapse/pull/3707) and so the unprefixed `limit_type` is being used in the wild. | ||
As such some clients also support this unprefixed version. | ||
|
||
## Dependencies | ||
|
||
None. | ||
|
||
[`M_RESOURCE_LIMIT_EXCEEDED`]: https://spec.matrix.org/v1.16/client-server-api/#other-error-codes | ||
[`m.server_notice`]: https://spec.matrix.org/v1.16/client-server-api/#mroommessagemserver_notice |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.