Skip to content

Conversation

@zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Oct 1, 2022

It seems to have been omitted in #1255.

Per MSC3771.

Preview: https://pr1261--matrix-spec-previews.netlify.app

@zecakeh zecakeh requested a review from a team as a code owner October 1, 2022 17:23
It seems to have been omitted in matrix-org#1255

Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh force-pushed the thread-receipt-endpoint branch from d82135f to 174fcf2 Compare October 1, 2022 17:24
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks for catching! We'll get this included in a patch release.

The changes overall look fairly sane to me. The error code description felt like a run-on sentence, so I've suggested making it a list (while also relaxing the language a bit).

@turt2live
Copy link
Member

hmm, this seems to be missing signoff on all the commits - @zecakeh are you able to provide it?

@zecakeh
Copy link
Contributor Author

zecakeh commented Oct 4, 2022

Signed-off-by: Kévin Commaille [email protected]

Is this enough?

@turt2live
Copy link
Member

it is! Thank you.

@turt2live turt2live merged commit d3d4afd into matrix-org:main Oct 4, 2022
turt2live added a commit that referenced this pull request Oct 4, 2022
* Receipts: Add thread_id to the /receipt endpoint

It seems to have been omitted in #1255

Signed-off-by: Kévin Commaille <[email protected]>

* changelog

Signed-off-by: Kévin Commaille <[email protected]>

* Fix missing backtick

* Apply suggestion for error description

Co-authored-by: Travis Ralston <[email protected]>

Signed-off-by: Kévin Commaille <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
@zecakeh zecakeh deleted the thread-receipt-endpoint branch November 9, 2022 08:55
clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
* Receipts: Add thread_id to the /receipt endpoint

It seems to have been omitted in matrix-org#1255

Signed-off-by: Kévin Commaille <[email protected]>

* changelog

Signed-off-by: Kévin Commaille <[email protected]>

* Fix missing backtick

* Apply suggestion for error description

Co-authored-by: Travis Ralston <[email protected]>

Signed-off-by: Kévin Commaille <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants