Skip to content

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented May 24, 2025

Based on #2141.

As per MSC2965.

Pull Request Checklist

Preview: https://pr2147--matrix-spec-previews.netlify.app

zecakeh added 2 commits June 3, 2025 20:10
As per MSC2965.

Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh force-pushed the server-metadata-discovery branch from eb7db56 to 693e9f7 Compare June 3, 2025 18:10
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits

Comment on lines +129 to +141
prompt_values_supported:
type: array
description: |-
List of OpenID Connect prompt values that the server supports at the
authorization endpoint.

Only the `create` value defined in [Initiating User Registration via OpenID
Connect](https://openid.net/specs/openid-connect-prompt-create-1_0.html) is
supported, for a client to signal to the server that the user desires to
register a new account.
items:
type: string
description: A prompt value that the server supports.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the historical record: this appears to have come from MSC2964.

Signed-off-by: Kévin Commaille <[email protected]>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is a conflict now

@zecakeh
Copy link
Contributor Author

zecakeh commented Jun 17, 2025

I merged main into my branch to solve the conflict, placing "Scope" after "Server metadata discovery".

@richvdh richvdh merged commit 51ccbbd into matrix-org:main Jun 17, 2025
12 checks passed
@richvdh
Copy link
Member

richvdh commented Jun 17, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants