Skip to content

Conversation

@robintown
Copy link
Member

MSC2873 specifies some actions for updating the widget's theme/language after it's loaded, and I'd like to make use of them.

@robintown robintown requested review from hughns and toger5 December 17, 2024 22:42
@robintown
Copy link
Member Author

Ehh, Sonar isn't supposed to care about coverage for a two line change…

MSC2873 specifies some actions for updating the widget's theme/language after it's loaded, and I'd like to make use of them.
@robintown robintown force-pushed the theme-language-changes branch from dd199d3 to b69a2e3 Compare January 2, 2025 18:52
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean.

Comment on lines +901 to +902
* Informs the widget that the client's theme has changed.
* @param theme The theme data, as an object with arbitrary contents.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the docstrings!

@robintown robintown merged commit 35d3e51 into master Jan 3, 2025
4 checks passed
@robintown robintown deleted the theme-language-changes branch January 3, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants