Add UPDATE_STATE widget api version #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
changed the base branch from
toger5/backwards-compatibility-for-UpdateState
to
master
toger5
force-pushed
the
toger5/backwards-compatibility-for-Update-State-no-perttier
branch
from
861beca to
367f47c
Compare
AndrewFerr
approved these changes
Jan 23, 2025
src/ClientWidgetApi.ts
Outdated
| */ | ||
| public async feedStateUpdate(rawEvent: IRoomEvent): Promise<void> { | ||
| if (rawEvent.state_key === undefined) throw new Error('Not a state event'); | ||
| const useUpdateState = (await this.getWidgetVersions()).includes(UnstableApiVersion.MSC2762_UPDATE_STATE); |
There was a problem hiding this comment.
Nitpick, this could be moved to line 1186 so that it won't be called unless needed. Then again, this will cache the result, so it shouldn't be expensive & should get called eventually.
|
toger5
deleted the
toger5/backwards-compatibility-for-Update-State-no-perttier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for: matrix-org/matrix-js-sdk#4652 (this pr also provides more background on why this is needed)
Let the client only send UpdateState if the widget supports it.